On Wed, Jan 13, 2021, Paolo Bonzini wrote: > On 13/01/21 05:12, Jason Baron wrote: > > > > > Looking at the vmx definitions I see quite a few that don't > > match that naming. For example: > > > > hardware_unsetup, > > hardware_enable, > > hardware_disable, > > report_flexpriority, > > update_exception_bitmap, > > enable_nmi_window, > > enable_irq_window, > > update_cr8_intercept, > > pi_has_pending_interrupt, > > cpu_has_vmx_wbinvd_exit, > > pi_update_irte, > > kvm_complete_insn_gp, > > > > So I'm not sure if we want to extend these macros to > > vmx/svm. > > Don't do it yourself, but once you introduce the new header it becomes a > no-brainer to switch the declarations to use it. So let's plan the new > header to make that switch easy. Ya, sorry if I didn't make it clear that the vmx/svm conversion is firmly out of scope for this series.
