On Mon, Jan 11, 2021, Sean Christopherson wrote: > On Mon, Jan 11, 2021, Tom Lendacky wrote: > > On 1/11/21 10:02 AM, Tom Lendacky wrote: > > > On 1/8/21 6:47 PM, Sean Christopherson wrote: > > > > Use "guest" instead of "enabled" for the global "running as an SEV guest" > > > > flag to avoid confusion over whether "sev_enabled" refers to the guest or > > > > the host. This will also allow KVM to usurp "sev_enabled" for its own > > > > purposes. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> > > > > > > Acked-by: Tom Lendacky <thomas.lendacky@xxxxxxx> > > > > Ah, I tried building with CONFIG_KVM=y and CONFIG_KVM_AMD=y and got a build > > error: > > > > In file included from arch/x86/kvm/svm/svm.c:43: > > arch/x86/kvm/svm/svm.h:222:20: error: ‘sev_guest’ redeclared as different > > kind of symbol > > Dang, didn't consider that scenario, obviously. The irony of introducing a > conflict while trying to avoid conflicts... Even better than coming up with a new name, sev_enabled can be removed entirely as it's really just sev_active() stored in a separate bool.
