Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
From: Alex Bennée <alex.bennee@xxxxxxxxxx>
Date: Mon, 11 Jan 2021 17:48:41 +0000
Cc: qemu-devel@xxxxxxxxxx, Huacai Chen <chenhuacai@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, qemu-trivial@xxxxxxxxxx, Amit Shah <amit@xxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, qemu-arm@xxxxxxxxxx, John Snow <jsnow@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Cornelia Huck <cohuck@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
In-reply-to: <20210111152020.1422021-3-philmd@redhat.com>
References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-3-philmd@redhat.com>
User-agent: mu4e 1.5.7; emacs 28.0.50

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> writes:

> The 'running' argument from VMChangeStateHandler does not require
> other value than 0 / 1. Make it a plain boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>

Seems reasonable

Reviewed-by: Alex Bennée <alex.bennee@xxxxxxxxxx>

-- 
Alex Bennée

References:
- [PATCH 0/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
  - From: Philippe Mathieu-Daudé
- [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
  - From: Philippe Mathieu-Daudé

Prev by Date: Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool
Next by Date: Re: [RFC PATCH 00/23] KVM SGX virtualization support
Previous by thread: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
Next by thread: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]