On 09/25/2009 10:03 PM, Jan Kiszka wrote:
Gleb Natapov wrote:
On Fri, Sep 25, 2009 at 06:05:49PM +0200, Jan Kiszka wrote:
The check for in-kernel irqchip must be protected by kvm_enabled, and we
have a different wrapper for it.
Why not move kvm_enabled() into kvm_irqchip_in_kernel()? It will return
false if !kvm_enabled().
Yes, possible. But I'm not sure if it's worth to refactor at this level.
In any case, fix bugs first, refactor later.
I think the whole irqchip interface has to go through some broader
refactoring when pushing it upstream. The result should either be a
specific, in-kernel-irqchip apic device or generic wrapper services that
cover all cases, is easily compiled away in the absence of KVM and avoid
#ifdefs like below.
s/when/before/
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
