On 12/14/20 3:51 PM, 罗勇刚(Yonggang Luo) wrote: > On Wed, Dec 9, 2020 at 6:09 AM Richard Henderson > <richard.henderson@xxxxxxxxxx <mailto:richard.henderson@xxxxxxxxxx>> wrote: >> >> On 12/6/20 5:39 PM, Philippe Mathieu-Daudé wrote: >> > The rest of helper.c is TLB related. Extract the non TLB >> > specific functions to a new file, so we can rename helper.c >> > as tlb_helper.c in the next commit. >> > >> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx > <mailto:f4bug@xxxxxxxxx>> >> > --- >> > Any better name? xxx_helper.c are usually TCG helpers. >> >> *shrug* perhaps cpu_common.c, no "helper" at all? >> Perhaps just move these bits to cpu.c? >> >> >> r~ >> > Does these are general cpu bits or misp_cpu bits? > if only misp cpu related, prefer misp_cpu.c > or cpu.c under misp folder. Yes, as the patch subject prefix implies, this is a change local to the target/mips/ directory. Regards, Phil.
