On 12/8/20 6:01 PM, Richard Henderson wrote: > On 12/8/20 5:56 PM, Richard Henderson wrote: >> On 12/7/20 6:36 PM, Philippe Mathieu-Daudé wrote: >>> Make gen_msa() and gen_msa_branch() public declarations >>> so we can keep calling them once extracted from the big >>> translate.c in the next commit. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> >>> --- >>> target/mips/translate.h | 2 ++ >>> target/mips/translate.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> > > Actually, I think this should be dropped, and two other patches rearranged. Actually, nevermind, you already get the right result in the end; there's no point re-rearranging. r~