Re: [kvm-unit-tests PATCH v2 4/7] lib/alloc_page: complete rewrite of the page allocator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 7 Dec 2020 16:41:18 -0800
Nadav Amit <nadav.amit@xxxxxxxxx> wrote:

> > On Oct 2, 2020, at 8:44 AM, Claudio Imbrenda
> > <imbrenda@xxxxxxxxxxxxx> wrote:
> > 
> > This is a complete rewrite of the page allocator.  
> 
> This patch causes me crashes:
> 
>   lib/alloc_page.c:433: assert failed: !(areas_mask & BIT(n))
> 
> It appears that two areas are registered on AREA_LOW_NUMBER, as
> setup_vm() can call (and calls on my system) page_alloc_init_area()
> twice.

which system is that? page_alloc_init_area should not be called twice
on the same area!

> setup_vm() uses AREA_ANY_NUMBER as the area number argument but
> eventually this means, according to the code, that
> __page_alloc_init_area() would use AREA_LOW_NUMBER.
> 
> I do not understand the rationale behind these areas well enough to
> fix it.

I'll see what I can fix


Claudio



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux