> On Dec 7, 2020, at 4:41 PM, Nadav Amit <nadav.amit@xxxxxxxxx> wrote: > >> On Oct 2, 2020, at 8:44 AM, Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> wrote: >> >> This is a complete rewrite of the page allocator. > > This patch causes me crashes: > > lib/alloc_page.c:433: assert failed: !(areas_mask & BIT(n)) > > It appears that two areas are registered on AREA_LOW_NUMBER, as setup_vm() > can call (and calls on my system) page_alloc_init_area() twice. > > setup_vm() uses AREA_ANY_NUMBER as the area number argument but eventually > this means, according to the code, that __page_alloc_init_area() would use > AREA_LOW_NUMBER. > > I do not understand the rationale behind these areas well enough to fix it. One more thing: I changed the previous allocator to zero any allocated page. Without it, I get strange failures when I do not run the tests on KVM, which are presumably caused by some intentional or unintentional hidden assumption of kvm-unit-tests that the memory is zeroed. Can you restore this behavior? I can also send this one-line fix, but I do not want to overstep on your (hopeful) fix for the previous problem that I mentioned (AREA_ANY_NUMBER). Thanks, Nadav
