Avi Kivity wrote: > On 09/22/2009 05:51 PM, Gleb Natapov wrote: >> Each caller of the function already calls it. >> >> Signed-off-by: Gleb Natapov<gleb@xxxxxxxxxx> >> --- >> hw/apic.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/hw/apic.c b/hw/apic.c >> index 3a2e128..a9d1fb8 100644 >> --- a/hw/apic.c >> +++ b/hw/apic.c >> @@ -488,7 +488,6 @@ void apic_init_reset(CPUState *env) >> if (!s) >> return; >> >> - cpu_synchronize_state(env); >> s->tpr = 0; >> s->spurious_vec = 0xff; >> s->log_dest = 0; >> > > Still, it's safer to live this in. > Yet another diff to upstream... It's really time to stabilize this still a bit fuzzy register sync model, also in qemu-kvm. If you think we need it, let us push it upstream - with a sound explanation, and maybe even with more sync points for the sake of consistency. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
