On 4 December 2020 18:27:34 GMT, Alexander Graf <graf@xxxxxxxxxx> wrote: >On 04.12.20 02:18, David Woodhouse wrote: >> From: David Woodhouse <dwmw@xxxxxxxxxxxx> >> >> It shouldn't take a vcpu. > >This is not a patch description. Please provide an actual rationale. What? If you aren't familiar with the KVM function nomenclature... since the function name is kvm_xxx() and it operates on the struct KVM, not kvm_vcpu_xxx() and it doesn't actually use the vCPU it's given except to get vcpu->kvm and operate on that... it shouldn't take a vcpu. But most of those words are superfluous to anyone who's paying attention. The rationale in the patch seems perfectly clear to me. > > > >Amazon Development Center Germany GmbH >Krausenstr. 38 >10117 Berlin >Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss >Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B >Sitz: Berlin >Ust-ID: DE 289 237 879 -- Sent from my Android device with K-9 Mail. Please excuse my brevity.