On 12/4/20 5:30 PM, Richard Henderson wrote: > On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: >> Extract the logic initialization of the MSA registers from >> the generic initialization. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> >> --- >> target/mips/translate.c | 35 ++++++++++++++++++++--------------- >> 1 file changed, 20 insertions(+), 15 deletions(-) > > Why? msa_wr_d[] registers are only used by MSA, so in the next series that allows me to move the 'static msa_wr_d[]' in msa_translate.c, without having to declare them global with extern. > >> - fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2]); >> + fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, fregnames[i]); > > Maybe fold this back to the previous patch? Certainly ;) > > > r~ >
