On Tue, Sep 22, 2009 at 07:40:10AM -0300, Fernando Carrijo wrote:
> Resending with Cc: added
>
> On Mon, 2009-09-21 at 20:37 -0300, Marcelo Tosatti wrote:
>
> > - kvm_arch_flush_shadow(kvm);
> > + flush_shadow = 1;
> > }
> > #else /* not defined CONFIG_S390 */
> > new.user_alloc = user_alloc;
> > @@ -641,34 +642,69 @@ skip_lpage:
> > new.userspace_addr = mem->userspace_addr;
> > #endif /* not defined CONFIG_S390 */
> >
> > - if (!npages)
> > + if (!npages) {
> > + slots = kzalloc(sizeof(struct kvm_memslots), GFP_KERNEL);
> > + if (!slots)
> > + goto out_free;
> > + memcpy(slots, kvm->memslots, sizeof(struct kvm_memslots));
>
> Nothing wrong with the above line, but it makes me think if
>
> *slots = *kvm->memslots;
>
> would save us the function call overhead
Perhaps. But this is a slow path anyway, so it does not matter much.
Thanks for the review.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
