Re: [patch 08/10] KVM: x86: switch kvm_set_memory_alias to SRCU update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/22/2009 02:37 AM, Marcelo Tosatti wrote:
Using a similar two-step procedure as for memslots.



-	gfn = unalias_gfn(kvm, gfn);
+	gfn = unalias_gfn(kvm, gfn, false);

To improve readability suggest two names, maybe unalias_gfn() and unalias_gfn_instantiation(). boolean parameters are hard to read at the call site.

Also we've discussed in the past converting aliases to private slots (and also echo aliases >> feature-removal-schedule.txt); maybe that is an easier way of verifying everything still works.


--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux