Hi Marc, > -----Original Message----- > From: Marc Zyngier <maz@xxxxxxxxxx> > Sent: Tuesday, November 24, 2020 5:07 PM > To: Jianyong Wu <Jianyong.Wu@xxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; yangbo.lu@xxxxxxx; john.stultz@xxxxxxxxxx; > tglx@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; sean.j.christopherson@xxxxxxxxx; > richardcochran@xxxxxxxxx; Mark Rutland <Mark.Rutland@xxxxxxx>; > will@xxxxxxxxxx; Suzuki Poulose <Suzuki.Poulose@xxxxxxx>; Andre > Przywara <Andre.Przywara@xxxxxxx>; Steven Price > <Steven.Price@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; Steve Capper <Steve.Capper@xxxxxxx>; Justin He > <Justin.He@xxxxxxx>; nd <nd@xxxxxxx> > Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. > > On 2020-11-24 05:20, Jianyong Wu wrote: > > Hi Marc, > > [...] > > >> > +/* ptp_kvm counter type ID */ > >> > +#define ARM_PTP_VIRT_COUNTER 0 > >> > +#define ARM_PTP_PHY_COUNTER 1 > >> > +#define ARM_PTP_NONE_COUNTER 2 > >> > >> The architecture definitely doesn't have this last counter. > > > > Yeah, this is just represent no counter data needed from guest. > > Some annotation should be added here. > > I'd rather you remove it entirely, or explain why you really cannot do without > a fake counter. OK, I will remove it. Thanks Jianyong > > M. > -- > Jazz is not dead. It just smells funny...
