On Thu, 19 Nov 2020 12:30:26 +0100 Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > > +static void vfio_mdev_request(void *device_data, unsigned int count) > > +{ > > + struct mdev_device *mdev = device_data; > > + struct mdev_parent *parent = mdev->parent; > > + > > + if (unlikely(!parent->ops->request)) > > Hm. Do you think that all drivers should implement a ->request() > callback? @Tony: What do you think, does vfio_ap need something like this? BTW how is this supposed to work in a setup where the one parent has may children (like vfio_ap or the gpu slice and dice usecases). After giving this some thought I'm under the impression, I don't get the full picture yet. Regards, Halil