Re: [PATCH v2 02/11] KVM: selftests: Remove deadcode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 11, 2020 at 01:26:27PM +0100, Andrew Jones wrote:
> Nothing sets USE_CLEAR_DIRTY_LOG anymore, so anything it surrounds
> is dead code.
> 
> Reviewed-by: Ben Gardon <bgardon@xxxxxxxxxx>
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>

It's kind of a pity that there seem to a few valid measurements for clear dirty
log from Ben. I'm just thinking whether clear dirty log should be even more
important since imho that should be the right way to use KVM_GET_DIRTY_LOG on a
kernel new enough, since it's a total win (not like dirty ring, which depends).

So far, the statement is definitely true above, since we can always work on
top.  So:

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

Thanks,

-- 
Peter Xu




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux