On Wed, Nov 11, 2020 at 03:08:59PM -0800, Ben Gardon wrote: > On Wed, Nov 11, 2020 at 4:27 AM Andrew Jones <drjones@xxxxxxxxxx> wrote: > > > > It's not conventional C to put non-inline functions in header > > files. Create a source file for the functions instead. Also > > reduce the amount of globals and rename the functions to > > something less generic. > > > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > > Reviewed-by: Ben Gardon <bgardon@xxxxxxxxxx> Thanks! > > + > > +void perf_test_add_vcpus(struct kvm_vm *vm, int vcpus, uint64_t vcpu_memory_bytes) > > NIT: Since we're actually creating the vcpus in vm_create_with_vcpus, > and renaming functions anyway, it might make sense to change this to > perf_test_setup_vcpus or similar here. > This could also be called from perf_test_create_vm and made static, > but that might be outside the scope of this commit. Either way works. > Yup, I agree there's still room for some more cleanup / renaming. I'll be happy to review the patches ;-) Thanks, drew
