Re: [PATCH 4/5 v4] KVM: VMX: Fill in conforming vmx_x86_ops via macro

[Like Xu <like.xu@xxxxxxxxxxxxxxx>]

Hi Krish,

On 2020/11/10 9:23, Krish Sadhukhan wrote:
> @@ -1192,7 +1192,7 @@ void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel,
>   	}
>   }
>   
> -void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
> +void vmx_prepare_guest_switch(struct kvm_vcpu *vcpu)

What do you think of renaming it to

	void vmx_prepare_switch_for_guest(struct kvm_vcpu *vcpu)；

?

Thanks,
Like Xu

>   {
>   	struct vcpu_vmx *vmx = to_vmx(vcpu);
>   	struct vmcs_host_state *host_state;
>
> @@ -311,7 +311,7 @@ void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu,
>   int allocate_vpid(void);
>   void free_vpid(int vpid);
>   void vmx_set_constant_host_state(struct vcpu_vmx *vmx);
> -void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu);
> +void vmx_prepare_guest_switch(struct kvm_vcpu *vcpu);
>   void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel,
>   			unsigned long fs_base, unsigned long gs_base);
>   int vmx_get_cpl(struct kvm_vcpu *vcpu);