On Mon, Nov 09, 2020 at 03:08:17PM +0100, Thomas Gleixner wrote: > On Mon, Nov 09 2020 at 12:14, Thomas Gleixner wrote: > > On Sun, Nov 08 2020 at 15:58, Ashok Raj wrote: > >> On Sun, Nov 08, 2020 at 07:47:24PM +0100, Thomas Gleixner wrote: > >> But for SIOV devices there is no PASID filtering at the remap level since > >> interrupt messages don't carry PASID in the TLP. > > > > Why do we need PASID for VMM integrity? > > > > If the device sends a message then the remap unit will see the requester > > ID of the device and if the message it sends is not > > That made me look at patch 4/17 which adds DEVMSI support to the > remap code: > > > + case X86_IRQ_ALLOC_TYPE_DEV_MSI: > > + irte_prepare_msg(msg, index, sub_handle); > > break; > > It does not setup any requester-id filter in IRTE. How is that supposed > to be correct? > Its missing a set_msi_sid() equivalent for the DEV_MSI type.