Hi Andrew, On 11/9/20 3:41 PM, Andrew Jones wrote: > On Wed, Nov 04, 2020 at 01:03:50PM +0000, Nikos Nikoleris wrote: >> Hi all, >> >> One more update to the series that allows us to configure the >> translation granule in arm64. Again, thanks to Drew and Alex for >> their reviews and their suggestions. >> >> v1: >> https://lore.kernel.org/kvm/006a19c0-cdf7-e76c-8335-03034bea9c7e@xxxxxxx/T >> v2: >> https://lore.kernel.org/kvm/20201102113444.103536-1-nikos.nikoleris@xxxxxxx/ >> >> >> Changes in v3: >> - Re-ordered the two changes in the series >> - Moved much of the code to check the configured granule from the C >> preprocessor to run time. >> - Avoid block mappings at the PUD level (Thanks Alex!) >> - Formatting changes >> >> Changes in v2: >> - Change the configure option from page-shift to page-size >> - Check and warn if the configured granule is not supported >> >> Thanks, >> >> Nikos >> >> >> Nikos Nikoleris (2): >> arm64: Check if the configured translation granule is supported >> arm64: Add support for configuring the translation granule >> >> configure | 27 ++++++++++++++ >> lib/arm/asm/page.h | 4 +++ >> lib/arm/asm/pgtable-hwdef.h | 4 +++ >> lib/arm/asm/pgtable.h | 6 ++++ >> lib/arm/asm/thread_info.h | 4 ++- >> lib/arm64/asm/page.h | 35 ++++++++++++++---- >> lib/arm64/asm/pgtable-hwdef.h | 42 +++++++++++++++++----- >> lib/arm64/asm/pgtable.h | 68 +++++++++++++++++++++++++++++++++-- >> lib/arm64/asm/processor.h | 36 +++++++++++++++++++ >> lib/libcflat.h | 20 ++++++----- >> lib/arm/mmu.c | 31 ++++++++++------ >> arm/cstart64.S | 10 +++++- >> 12 files changed, 249 insertions(+), 38 deletions(-) >> >> -- >> 2.17.1 >> > Looks good to me. > > Alex, did you plan to review again? Yes, I forgot about it, sorry. I'll review them as soon as possible (tomorrow most likely). Thanks, Alex
