Re: [PATCH 0/4] KVM: selftests: Add get-reg-list regression test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 29, 2020 at 09:16:59PM +0100, Andrew Jones wrote:
> Since Eric complained in his KVM Forum talk that there weren't any
> aarch64-specific KVM selftests, now he gets to review one. This test
> was inspired by recent regression report about get-reg-list losing
> a register between an old kernel version and a new one.
> 
> Thanks,
> drew
> 
> 
> Andrew Jones (4):
>   KVM: selftests: Don't require THP to run tests
>   KVM: selftests: Add aarch64 get-reg-list test
>   KVM: selftests: Update aarch64 get-reg-list blessed list
>   KVM: selftests: Add blessed SVE registers to get-reg-list
>

Paolo,

I see you silently applied this series to kvm/master, but there's a
v2 of the series on the list which incorporates Marc's comments. And,
the application of the series is bad, because you've squashed "Update
aarch64 get-reg-list blessed list" into "Add aarch64 get-reg-list test".
Those were created as separate patches on purpose in order for the
commit message of "Add aarch64 get-reg-list test" to reflect the kernel
version from which the blessed reg list was primed and the commit
message of "Update aarch64 get-reg-list blessed list" to explicitly
point out the new commits that introduce the new registers since the
priming kernel version up to the current kernel version. The division
was also done to ensure the same pattern is used for future updates of
the list.

Thanks,
drew




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux