Re: [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test

Subject: Re: [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 6 Nov 2020 19:15:31 +0100
Cc: kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Sean Christopherson <sean.j.christopherson@xxxxxxxxx>, "Dr . David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Andrew Jones <drjones@xxxxxxxxxx>
In-reply-to: <20201106180610.GC138364@xz-x1>
References: <20201001012044.5151-1-peterx@redhat.com> <20201001012239.6159-1-peterx@redhat.com> <6d5eb99e-e068-e5a6-522f-07ef9c33127f@redhat.com> <20201106180610.GC138364@xz-x1>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 06/11/20 19:06, Peter Xu wrote:

+	pthread_sigmask(0, NULL, sigset);

Not extremely important, but still better with SIG_BLOCK imho, since it seems
not all archs defined SIG_BLOCK as zero.


If the second argument is NULL, the first is unused.

Paolo

Follow-Ups:
- Re: [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test
  - From: Peter Xu

References:
- [PATCH v13 00/14] KVM: Dirty ring interface
  - From: Peter Xu
- [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test
  - From: Peter Xu
- Re: [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test
  - From: Paolo Bonzini
- Re: [PATCH v13 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test
  - From: Peter Xu