On Thu, Nov 05, 2020 at 10:59:30AM +0100, Andrew Jones wrote: > > >> +#define PTRS_PER_PAGE(page_size) ((page_size) / 8) > > > > > > Doh. I think this 8 is supposed to be a 16 for s390x, considering it > > > was dividing by 256 in its version of vm_create_default. I need > > > guidance from s390x gurus as to whether or not I should respin though. > > > > > > Thanks, > > > drew > > > > > > > This is kind of tricky. The last level page table is only 2kb (256 entries = 1MB range). > > Depending on whether the page table allocation is clever or not (you can have 2 page > > tables in one page) this means that indeed 16 might be better. But then you actually > > want to change the macro name to PTES_PER_PAGE? > > Thanks Christian, > > I'll respin with the macro name change and 16 for s390. Maybe it can also be moved to common header, but instead define PTR_SIZE for per-arch? I'm also curious whether PTR_SIZE will equals to "sizeof(void *)", but seems not for s390x.. Thanks, -- Peter Xu
