On Wednesday, 2020-11-04 at 23:53:01 -08, Nadav Amit wrote: >> On Nov 3, 2020, at 8:08 AM, David Edmondson <david.edmondson@xxxxxxxxxx> wrote: >> >> Verify that the clflushopt instruction succeeds when applied to an >> MMIO address at both cpl0 and cpl3. >> >> Suggested-by: Joao Martins <joao.m.martins@xxxxxxxxxx> >> Signed-off-by: David Edmondson <david.edmondson@xxxxxxxxxx> >> > > [snip] > >> + ret = pci_find_dev(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_TEST); >> + if (ret != PCIDEVADDR_INVALID) { >> + pci_dev_init(&pcidev, ret); > > Just wondering, and perhaps this question is more general: does this test > really need the Red-Hat test device? > > I know it is an emulated device, but can’t we use some other MMIO address > (e.g., PIT) that is also available on bare-metal? If it's acceptable to assume that HPET is present and at 0xfed00000, then it could be used. dme. -- Does everyone stare the way I do?