Track asid from svm->asid to allow for vmcb assignment without regard to which level guest is running. Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Signed-off-by: Cathy Avery <cavery@xxxxxxxxxx> --- arch/x86/kvm/svm/svm.c | 16 ++++++++++++++-- arch/x86/kvm/svm/svm.h | 2 ++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index d4e18bda19c7..83b4f56883f8 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -1101,6 +1101,7 @@ static void init_vmcb(struct vcpu_svm *svm) save->cr4 = 0; } svm->asid_generation = 0; + svm->asid = 0; svm->nested.vmcb = 0; svm->vcpu.arch.hflags = 0; @@ -1659,11 +1660,11 @@ static void new_asid(struct vcpu_svm *svm, struct svm_cpu_data *sd) if (sd->next_asid > sd->max_asid) { ++sd->asid_generation; sd->next_asid = sd->min_asid; - svm->vmcb->control.tlb_ctl = TLB_CONTROL_FLUSH_ALL_ASID; + sd->flush_all_asid = true; } svm->asid_generation = sd->asid_generation; - svm->vmcb->control.asid = sd->next_asid++; + svm->asid = sd->next_asid++; vmcb_mark_dirty(svm->vmcb, VMCB_ASID); } @@ -3030,6 +3031,17 @@ static void pre_svm_run(struct vcpu_svm *svm) /* FIXME: handle wraparound of asid_generation */ if (svm->asid_generation != sd->asid_generation) new_asid(svm, sd); + + if (sd->flush_all_asid) { + svm->vmcb->control.tlb_ctl = TLB_CONTROL_FLUSH_ALL_ASID; + sd->flush_all_asid = false; + vmcb_mark_dirty(svm->vmcb, VMCB_ASID); + } + + if (unlikely(svm->asid != svm->vmcb->control.asid)) + vmcb_mark_dirty(svm->vmcb, VMCB_ASID); + + svm->vmcb->control.asid = svm->asid; } static void svm_inject_nmi(struct kvm_vcpu *vcpu) diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index a798e1731709..22832362bced 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -104,6 +104,7 @@ struct vcpu_svm { struct vmcb *vmcb; unsigned long vmcb_pa; struct svm_cpu_data *svm_data; + u32 asid; uint64_t asid_generation; uint64_t sysenter_esp; uint64_t sysenter_eip; @@ -164,6 +165,7 @@ struct svm_cpu_data { int cpu; u64 asid_generation; + bool flush_all_asid; u32 max_asid; u32 next_asid; u32 min_asid; -- 2.20.1