On Thu, Oct 22 2020 at 23:43, Thomas Gleixner wrote:
> On Fri, Oct 09 2020 at 11:46, David Woodhouse wrote:
> Aside of that it works magically because polarity,trigger and mask bit
> have been set up before. But of course a comment about this is
> completely overrated.
Also this part:
> -static void mp_setup_entry(struct irq_cfg *cfg, struct mp_chip_data *data,
> - struct IO_APIC_route_entry *entry)
> +static void mp_setup_entry(struct irq_data *irq_data, struct mp_chip_data *data)
> {
> + struct IO_APIC_route_entry *entry = &data->entry;
> +
> memset(entry, 0, sizeof(*entry));
> - entry->delivery_mode = apic->irq_delivery_mode;
> - entry->dest_mode = apic->irq_dest_mode;
> - entry->dest = cfg->dest_apicid & 0xff;
> - entry->virt_ext_dest = cfg->dest_apicid >> 8;
> - entry->vector = cfg->vector;
> +
> + mp_swizzle_msi_dest_bits(irq_data, entry);
> +
> entry->trigger = data->trigger;
> entry->polarity = data->polarity;
> /*
does not make sense. It did not make sense before either, but now it
does even make less sense.
During allocation this only needs to setup the I/O-APIC specific bits
(trigger, polarity, mask). The rest is filled in when the actual
activation happens. Nothing writes that entry _before_ activation.
/me goes to mop up more
