> On Oct 19, 2020, at 9:37 AM, Christopherson, Sean J <sean.j.christopherson@xxxxxxxxx> wrote: > > On Mon, Oct 19, 2020 at 01:32:00PM +0200, Vitaly Kuznetsov wrote: >> Sean Christopherson <sean.j.christopherson@xxxxxxxxx> writes: >>> E.g. does running 1M loops in test_multiple_nmi() really add value versus >>> say 10k or 100k loops? >> >> Oddly enough, I vaguely remember this particular test hanging >> *sometimes* after a few thousand loops but I don't remember any >> details. > > Thousands still ain't millions :-D. > > IMO, the unit tests should sit between a smoke test and a long running, > intensive stress test, i.e. the default config shouldn't be trying to find > literal one-in-a-million bugs on every run. IIRC, this test failed on VMware, and according to our previous discussions, does not follow the SDM as NMIs might be collapsed [1]. [1] https://marc.info/?l=kvm&m=145876994031502&w=2
