On 14/10/20 20:26, Ben Gardon wrote: > + > +static void put_tdp_mmu_root(struct kvm *kvm, struct kvm_mmu_page *root) > +{ > + if (kvm_mmu_put_root(root)) > + kvm_tdp_mmu_free_root(kvm, root); > +} Unused... > +static void get_tdp_mmu_root(struct kvm *kvm, struct kvm_mmu_page *root) > +{ > + lockdep_assert_held(&kvm->mmu_lock); > + > + kvm_mmu_get_root(root); > +} > + ... and duplicate with kvm_mmu_get_root itself since we can move the assertion there. Paolo