Re: [PATCH] vfio/fsl-mc: fix the return of the uninitialized variable ret

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/15/2020 9:52 PM, Alex Williamson wrote:
On Thu, 15 Oct 2020 13:22:26 +0100
Colin King <colin.king@xxxxxxxxxxxxx> wrote:

From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Currently the success path in function vfio_fsl_mc_reflck_attach is
returning an uninitialized value in variable ret. Fix this by setting
this to zero to indicate success.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: f2ba7e8c947b ("vfio/fsl-mc: Added lock support in preparation for interrupt handling")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
  drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
index 80fc7f4ed343..42a5decb78d1 100644
--- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c
+++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
@@ -84,6 +84,7 @@ static int vfio_fsl_mc_reflck_attach(struct vfio_fsl_mc_device *vdev)
  		vfio_fsl_mc_reflck_get(cont_vdev->reflck);
  		vdev->reflck = cont_vdev->reflck;
  		vfio_device_put(device);
+		ret = 0;
  	}
unlock:

Looks correct to me, unless Diana would rather set the initial value to
zero instead.  Thanks,

Alex



I prefer to initialize the variable to 0 when it's defined. I'll send a patch for it.

Thanks,
Diana



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux