On 10 October 2020 12:44:10 BST, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: >On Sat, Oct 10 2020 at 11:06, David Woodhouse wrote: >> On Fri, 2020-10-09 at 01:27 +0200, Thomas Gleixner wrote: >>> On Thu, Oct 08 2020 at 22:39, David Woodhouse wrote: >>> For the next submission, can you please >>> >>> - pick up the -ENODEV changes for HPET/IOAPIC which I posted >earlier >> >> I think the world will be a nicer place if HPET and IOAPIC have their >> own struct device and their drivers can just use >dev_get_msi_domain(). >> >> The IRQ remapping drivers already plug into the device-add notifier >and >> can fill in the appropriate MSI domain just like they do¹ for PCI and >> ACPI devices. >> >> Using platform_add_bundle() for HPET looks trivial enough; I'll have >a >> play with that and then do IOAPIC too if/when the initialisation >order >> and hotplug handling all works out OK to install the correct >> msi_domain. > >Yes, I was wondering about that when I made PCI at least use that >mechanism, but had not had time to actually look at it. Yeah. There's some muttering to be done for HPET about whether it's *its* MSI domain or whether it's the parent domain. But I'll have a play. I think we'll be able to drop the whole irq_remapping_get_irq_domain() thing. Either way, it's a separate cleanup and the 15-bit APIC ID series I posted yesterday should be fine as it is. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
