On 30/09/20 18:37, Sean Christopherson wrote: >> + >> + if (WARN_ON(!VALID_PAGE(vcpu->arch.mmu->root_hpa))) >> + return RET_PF_RETRY; > I feel like we should kill off these silly WARNs in the existing code instead > of adding more. If they actually fired, I'm pretty sure that they would > continue firing and spamming the kernel log until the VM is killed as I don't > see how restarting the guest will magically fix anything. This is true, but I think it's better to be defensive. They're certainly all candidates for KVM_BUG_ON. Paolo
