On 25/09/20 23:22, Ben Gardon wrote: > +static void handle_changed_spte_dlog(struct kvm *kvm, int as_id, gfn_t gfn, > + u64 old_spte, u64 new_spte, int level) > +{ > + bool pfn_changed; > + struct kvm_memory_slot *slot; _dlog is a new abbreviation... I think I prefer the full _dirty_log, it's not any longer than _acc_track. I wonder if it's worth trying to commonize code between the TDP MMU, mmu_spte_update and fast_pf_fix_direct_spte. But that can be left for later since this is only a first step. Paolo