On Sat, 19 Sep 2020 11:34:28 -0400 Matthew Rosato <mjrosato@xxxxxxxxxxxxx> wrote: > From: Pierre Morel <pmorel@xxxxxxxxxxxxx> > > To have a clean separation between s390-pci-bus.h and s390-pci-inst.h > headers we export the PCI CLP instructions in a dedicated header. > > Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> > Signed-off-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx> > --- > hw/s390x/s390-pci-bus.h | 1 + > hw/s390x/s390-pci-clp.h | 211 +++++++++++++++++++++++++++++++++++++++++++++++ > hw/s390x/s390-pci-inst.h | 196 ------------------------------------------- > 3 files changed, 212 insertions(+), 196 deletions(-) > create mode 100644 hw/s390x/s390-pci-clp.h Looks sane; but I wonder whether we should move the stuff under include/hw/s390x/.