On Thu, Sep 24, 2020 at 02:42:19PM +0200, Vitaly Kuznetsov wrote: > What about kvm_mmu_get_page(), make_mmu_pages_available(), > mmu_alloc_root(), kvm_mmu_sync_roots(), direct_page_fault(), > kvm_mmu_pte_write() which seem to be using the same ugly pattern? :-) Heh, good question. I guess only kvm_mmu_free_roots() managed to cross over the threshold from "that's ugly" to "this is ridiculous".
