Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/9/24 下午3:50, Michael S. Tsirkin wrote:
On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote:
Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features")
introduces two malfunction backend features ioctls:

1) the ioctls was blindly added to vring ioctl instead of vdpa device
    ioctl
2) vhost_set_backend_features() was called when dev mutex has already
    been held which will lead a deadlock

This patch fixes the above issues.

Cc: Eli Cohen<elic@xxxxxxxxxx>
Reported-by: Zhu Lingshan<lingshan.zhu@xxxxxxxxx>
Fixes: 653055b9acd4 ("vhost-vdpa: support get/set backend features")
Signed-off-by: Jason Wang<jasowang@xxxxxxxxxx>
Don't we want the fixes queued right now, as opposed to the rest of the
RFC?


Yes, actually I've posted in before[1].

Adding the patch here is to simplify the work for the guys that want to do the work on top. E.g for Cindy to start the Qemu prototype.

Thanks

[1] https://www.spinics.net/lists/netdev/msg681247.html





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux