On 23/09/20 19:22, Sean Christopherson wrote: > On Wed, Sep 23, 2020 at 07:20:17PM +0200, Paolo Bonzini wrote: >> On 23/09/20 18:50, Sean Christopherson wrote: >>> Add a helper function and several wrapping macros to consolidate the >>> copy-paste code in vmx_compute_secondary_exec_control() for adjusting >>> controls that are dependent on guest CPUID bits. >>> >>> No functional change intended. >>> >>> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> >>> --- >>> arch/x86/kvm/vmx/vmx.c | 128 +++++++++++++---------------------------- >>> 1 file changed, 41 insertions(+), 87 deletions(-) >> >> The diffstat is enticing but the code a little less so... Can you just >> add documentation above vmx_adjust_secondary_exec_control that explains >> the how/why? > > Ya, I'd be more than happy to add a big comment. > Ok, I'll wait for v2 of this patch only. Paolo
