Re: KVM: x86: emulating RDPID failure shall return #UD rather than #GP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/08/20 04:23, Robert Hoo wrote:
> Per Intel's SDM, RDPID takes a #UD if it is unsupported, which is more or
> less what KVM is emulating when MSR_TSC_AUX is not available.  In fact,
> there are no scenarios in which RDPID is supposed to #GP.
> 
> Fixes: fb6d4d340e (KVM: x86: emulate RDPID)
> Signed-off-by: Robert Hoo <robert.hu@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/kvm/emulate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index d0e2825..571cb86 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3594,7 +3594,7 @@ static int em_rdpid(struct x86_emulate_ctxt *ctxt)
>  	u64 tsc_aux = 0;
>  
>  	if (ctxt->ops->get_msr(ctxt, MSR_TSC_AUX, &tsc_aux))
> -		return emulate_gp(ctxt, 0);
> +		return emulate_ud(ctxt);
>  	ctxt->dst.val = tsc_aux;
>  	return X86EMUL_CONTINUE;
>  }
> 

Queued, thanks.

Paolo




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux