On 22/09/20 21:11, Babu Moger wrote: > > >> -----Original Message----- >> From: Paolo Bonzini <pbonzini@xxxxxxxxxx> >> Sent: Tuesday, September 22, 2020 8:39 AM >> To: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> >> Cc: Moger, Babu <Babu.Moger@xxxxxxx>; vkuznets@xxxxxxxxxx; >> jmattson@xxxxxxxxxx; wanpengli@xxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; >> joro@xxxxxxxxxx; x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> mingo@xxxxxxxxxx; bp@xxxxxxxxx; hpa@xxxxxxxxx; tglx@xxxxxxxxxxxxx >> Subject: Re: [PATCH v6 04/12] KVM: SVM: Modify intercept_exceptions to >> generic intercepts >> >> On 14/09/20 17:06, Sean Christopherson wrote: >>>> I think these should take a vector instead, and add 64 in the functions. >>> >>> And "s/int bit/u32 vector" + BUILD_BUG_ON(vector > 32)? >> >> Not sure if we can assume it to be constant, but WARN_ON_ONCE is good >> enough as far as performance is concerned. The same int->u32 + >> WARN_ON_ONCE should be done in patch 1. > > Paolo, Ok sure. Will change "int bit" to "u32 vector". I will send a new > patch to address this. This needs to be addressed in all these functions, > vmcb_set_intercept, vmcb_clr_intercept, vmcb_is_intercept, > set_exception_intercept, clr_exception_intercept, svm_set_intercept, > svm_clr_intercept, svm_is_intercept. > > Also will add WARN_ON_ONCE(vector > 32); on set_exception_intercept, > clr_exception_intercept. Does that sound good? I can do the fixes myself, no worries. It should get to kvm/next this week. Paolo
