On 14/09/20 22:43, Krish Sadhukhan wrote: >> > > Not related to your changes, but should we get rid of the variable > 'exit_fastpath' and just do, > > return svm_exit_handler_fastpath(vcpu); > > It seems the variable isn't used anywhere else and svm_vcpu_run() > doesn't return from anywhere else either. Yes (also because vmx will do the same once we can push EXIT_FASTPATH_REENTER_GUEST handling up to vcpu_enter_guest)... > Also, svm_exit_handlers_fastpath() doesn't have any other caller. > Should we get rid of it as well ? ... and no, because svm_vcpu_run is a very large function and therefore it's better to keep its flow streamlined. Paolo
