On 19/09/20 11:18, Thomas Huth wrote: >>> >>> So I define like this: >>> >>> #define KVM_VM_MIPS_AUTO 0 >>> #define KVM_VM_MIPS_VZ 1 >>> #define KVM_VM_MIPS_TE 2 >>> >>> Since VZ and TE cannot co-exists, using type 0 on a TE platform will >>> still return success (so old user-space tools have no problems on new >>> kernels); the advantage is that using type 0 on a VZ platform will not >>> return failure. So, the only problem is "new user-space tools use type >>> 2 on old kernels", but if we treat this as a kernel bug, we can backport >>> this patch to old stable kernels. >> I'm a bit wary to do that. However it's not an issue for QEMU since it >> generally updates the kernel headers. > Are there any other userspace programs beside QEMU that use KVM on MIPS? > If there aren't any other serious userspace programs, I think we should > go ahead with this patch here. Otherwise, what are the other programs > that could be affected? kvmtool (aka lkvm) I guess. I don't know if it is affected but I wouldn't be worried. Paolo
