On Sat, Sep 12, 2009 at 08:04:31PM +0300, Izik Eidus wrote: >>>> If change_pte is called to modify a largepage pte, and the shadow has >>>> that largepage mapped with 4k sptes, you'll set the wrong pfn. That is, >>>> the patch does not attempt to handle different page sizes properly. >>>> >>>> So either disable change_pte updates to non-4k host vmas (making it >>>> explictly it does not handle different pagesizes), or handle largepages >>>> properly, although i don't see any use for change_pte or largepage >>>> mappings? >>>> >>> change_pte doesn't get called on 4k pages... >>> So adding commet to this function saying it is working just on 4k >>> pages would be enough ? >>> >> >> It would be better to fail/WARN on non-4k host ptes (can't it?), but if >> that is not possible i think a comment would be enough. >> >> > Ok so you want is_large_pte() check on data right? (and WARN() there..) pte_huge(pte), yeah. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
