On Thu, Sep 10, 2020 at 09:18:41AM +0200, Guennadi Liakhovetski wrote: > On Wed, Sep 09, 2020 at 04:45:21PM -0600, Mathieu Poirier wrote: > > On Wed, Aug 26, 2020 at 07:46:35PM +0200, Guennadi Liakhovetski wrote: > > > rpmsg_create_ept() takes struct rpmsg_channel_info chinfo as its last > > > argument, not a u32 value. The first two arguments are also updated. > > > > > > Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx> > > > --- > > > Documentation/rpmsg.txt | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt > > > index 24b7a9e1a5f9..1ce353cb232a 100644 > > > --- a/Documentation/rpmsg.txt > > > +++ b/Documentation/rpmsg.txt > > > @@ -192,9 +192,9 @@ Returns 0 on success and an appropriate error value on failure. > > > > > > :: > > > > > > - struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_channel *rpdev, > > > - void (*cb)(struct rpmsg_channel *, void *, int, void *, u32), > > > - void *priv, u32 addr); > > > + struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev, > > > + rpmsg_rx_cb_t cb, void *priv, > > > + struct rpmsg_channel_info chinfo); > > > > Again I don't see this being used in this set... It should have been sent on > > its own to the remoteproc and documentation mailing list. Note that > > Documentation/rpmsg.txt is now Documentation/staging/rpmsg.rst But you haven't pulled that change into your tree yet. Should I send as is for now or wait for you to cherry-pick that change? > Sure, can send it separately. > > Thanks > Guennadi > > > > every rpmsg address in the system is bound to an rx callback (so when > > > inbound messages arrive, they are dispatched by the rpmsg bus using the > > > -- > > > 2.28.0 > > >
