On Mon, Aug 24, 2020 at 10:54:47AM +0200, Joerg Roedel wrote: > + if (bytes == 4) > + *reg_data = 0; /* Zero-extend for 32-bit operation */ Please put all side-comments over the respective line. There are a couple in this patch. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette