On Thu, 2020-08-20 at 12:19 +0200, Paolo Bonzini wrote: > On 20/08/20 12:00, Maxim Levitsky wrote: > > > Please use vmcb12_gpa, and svm->nested.vmcb12 for the VMCB in patch 6. > > > > > > (You probably also what to have local variables named vmcb12 in patch 6 > > > to avoid too-long lines). > > The limit was raised to 100 chars recently, thats why I allowed some lines to > > go over 80 characters to avoid adding too much noise. > > > > True, but having svm->nested.vmcb12->control repeated all over isn't > pretty. :) I fully agree that adding local variable is a good idea anyway. I was just noting that svm->nested.vmcb is already about the nested (e.g vmcb12) thus I was thinking that naming this field vmcb12 would be redundant and not accepted this way. Best regards, Maxim Levitsky > > Since you're going to touch all lines anyway, adding the local variable > is a good idea. > > Paolo >
