Re: [PATCH 47/56] KVM: arm64: timers: Move timer registers to the sys_regs file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-08-19 10:24, Jianyong Wu wrote:
Hi Marc,

-----Original Message-----
From: kvmarm-bounces@xxxxxxxxxxxxxxxxxxxxx
<kvmarm-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Marc Zyngier
Sent: Thursday, August 6, 2020 1:57 AM
To: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Cc: Peng Hao <richard.peng@xxxxxxxx>; kernel-team@xxxxxxxxxxx;
kvm@xxxxxxxxxxxxxxx; Will Deacon <will@xxxxxxxxxx>; Catalin Marinas
<Catalin.Marinas@xxxxxxx>; Alexander Graf <graf@xxxxxxxxxx>;
kvmarm@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Subject: [PATCH 47/56] KVM: arm64: timers: Move timer registers to the
sys_regs file

Move the timer gsisters to the sysreg file. This will further help
when they are directly changed by a nesting hypervisor in the VNCR
page.

This requires moving the initialisation of the timer struct so that
some of the helpers (such as arch_timer_ctx_index) can work correctly
at an early stage.

Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
---
 arch/arm64/include/asm/kvm_host.h |   6 ++
 arch/arm64/kvm/arch_timer.c       | 155 +++++++++++++++++++++++-------
 arch/arm64/kvm/trace_arm.h        |   8 +-
 include/kvm/arm_arch_timer.h      |  11 +--
 4 files changed, 136 insertions(+), 44 deletions(-)

+static u64 timer_get_offset(struct arch_timer_context *ctxt) {
+	struct kvm_vcpu *vcpu = ctxt->vcpu;
+
+	switch(arch_timer_ctx_index(ctxt)) {
+	case TIMER_VTIMER:
+		return __vcpu_sys_reg(vcpu, CNTVOFF_EL2);
+	default:
+		return 0;
+	}
+}
+
Can I export this helper? As in my ptp_kvm implementation I need get
VCNT offset value separately not just give me a result of VCNT.

Sorry, you need to give me a bit more context. What do you need
the offset for exactly?

        M.
--
Jazz is not dead. It just smells funny...



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux