On 18.08.20 23:15, Aaron Lewis wrote:
It's not desireable to have all MSRs always handled by KVM kernel space. Some
MSRs would be useful to handle in user space to either emulate behavior (like
uCode updates) or differentiate whether they are valid based on the CPU model.
To allow user space to specify which MSRs it wants to see handled by KVM,
this patch introduces a new ioctl to push allow lists of bitmaps into
KVM. Based on these bitmaps, KVM can then decide whether to reject MSR access.
With the addition of KVM_CAP_X86_USER_SPACE_MSR it can also deflect the
denied MSR events to user space to operate on.
If no allowlist is populated, MSR handling stays identical to before.
Signed-off-by: KarimAllah Ahmed <karahmed@xxxxxxxxx>
Signed-off-by: Alexander Graf <graf@xxxxxxxxxx>
Same here, SoB line is missing.
I also see that you didn't address the nits you had on this patch:
[...]
>> + Filter booth read and write accesses to MSRs using the given
bitmap. A 0
>> + in the bitmap indicates that both reads and writes should
immediately fail,
>> + while a 1 indicates that reads and writes should be handled by
the normal
>> + KVM MSR emulation logic.
>
> nit: Filter both
[...]
>> +/* Maximum size of the of the bitmap in bytes */
>
> nit: "of the" is repeated twice
Feel free to change them in your patch setand add a note between the SoB
lines:
Signed-off-by: KarimAllah Ahmed <karahmed@xxxxxxxxx
Signed-off-by: Alexander Graf <graf@xxxxxxxxxx>
[aaronlewis: s/of the of the/of the/, s/booth/both/]
Signed-off-by: Aaron Lewis <aaronlewis@xxxxxxxxxx>
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
