Hi Marc, On 2020/8/17 20:52, Marc Zyngier wrote: > On 2020-08-17 13:24, Keqian Zhu wrote: >> In commit 0ea415390cd3 (clocksource/arm_arch_timer: Use arch_timer_read_counter >> to access stable counters), we separate stable and normal count reader. Actually >> the stable reader can correctly lead us to normal reader if we has no >> workaround. > > Resulting in an unnecessary overhead on non-broken systems that can run > without CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND. Not happening. OK, so I got the purpose of that patch wrong. > >> Besides, in erratum_set_next_event_tval_generic(), we use normal reader, it is >> obviously wrong, so just revert this commit to solve this problem by the way. > > If you want to fix something, post a patch that does exactly that. > I will. Thanks, Keqian > M.
