On Mon, Aug 10, 2020 at 10:05:17AM -0400, Michael S. Tsirkin wrote:
> On Fri, Aug 07, 2020 at 03:55:10PM -0400, Vivek Goyal wrote:
> > From: Sebastien Boeuf <sebastien.boeuf@xxxxxxxxx>
> >
> > On PCI the shm regions are found using capability entries;
> > find a region by searching for the capability.
> >
> > Signed-off-by: Sebastien Boeuf <sebastien.boeuf@xxxxxxxxx>
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx>
> > Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
> > Cc: kvm@xxxxxxxxxxxxxxx
> > Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
>
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>
[..]
> > +static bool vp_get_shm_region(struct virtio_device *vdev,
> > + struct virtio_shm_region *region, u8 id)
> > +{
> > + struct virtio_pci_device *vp_dev = to_vp_device(vdev);
> > + struct pci_dev *pci_dev = vp_dev->pci_dev;
> > + u8 bar;
> > + u64 offset, len;
> > + phys_addr_t phys_addr;
> > + size_t bar_len;
> > +
> > + if (!virtio_pci_find_shm_cap(pci_dev, id, &bar, &offset, &len)) {
> > + return false;
> > + }
> > +
> > + phys_addr = pci_resource_start(pci_dev, bar);
> > + bar_len = pci_resource_len(pci_dev, bar);
> > +
> > + if ((offset + len) < offset) {
> > + dev_err(&pci_dev->dev, "%s: cap offset+len overflow detected\n",
> > + __func__);
> > + return false;
> > + }
> > +
> > + if (offset + len > bar_len) {
> > + dev_err(&pci_dev->dev, "%s: bar shorter than cap offset+len\n",
> > + __func__);
> > + return false;
> > + }
>
> Maybe move this to a common header so the checks can be reused by
> other transports? Can be a patch on top.
Will do as patch on top once these patches get merged.
Thanks
Vivek
