On Wed, Aug 05, 2020 at 07:18:39PM +0000, Dey, Megha wrote: > Hence we will only have one create_dev_msi_domain which can be > called by any device driver that wants to use the dev-msi IRQ domain > to alloc/free IRQs. It would be the responsibility of the device > driver to provide the correct device and update the dev->msi_domain. I'm not sure that sounds like a good idea, why should a device driver touch dev->msi_domain? There was a certain appeal to the api I suggested by having everything related to setting up the new IRQs being in the core code. Jason