Re: [PATCH V5 1/6] vhost: introduce vhost_vring_call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/8/4 下午5:21, Michael S. Tsirkin wrote:
   +struct vhost_vring_call {
+    struct eventfd_ctx *ctx;
+    struct irq_bypass_producer producer;
+    spinlock_t ctx_lock;
It's not clear to me why we need ctx_lock here.

Thanks
Hi Jason,

we use this lock to protect the eventfd_ctx and irq from race conditions,
We don't support irq notification from vDPA device driver in this version,
do we still have race condition?

Thanks
Jason I'm not sure what you are trying to say here.


I meant we change the API from V4 so driver won't notify us if irq is changed.

Then it looks to me there's no need for the ctx_lock, everyhing could be synchronized with vq mutex.

Thanks







[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux